flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9936) Mesos resource manager unable to connect to master after failover
Date Mon, 30 Jul 2018 11:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16561795#comment-16561795
] 

ASF GitHub Bot commented on FLINK-9936:
---------------------------------------

yanghua commented on a change in pull request #6451: [FLINK-9936] Resource manager connect
to mesos after leadership granted. .
URL: https://github.com/apache/flink/pull/6451#discussion_r206098411
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -283,7 +287,14 @@ protected void initialize() throws ResourceManagerException {
 		connectionMonitor.tell(new ConnectionMonitor.Start(), selfActor);
 		schedulerDriver.start();
 
-		LOG.info("Mesos resource manager initialized.");
+		LOG.info("Mesos resource manager started.");
+	}
+
+	@Override
+	protected void onLeaderShipRevoked() throws Exception {
+		workerStore.stop(false);
 
 Review comment:
   We should warp try/catch block for these three calls to make sure they can be stopped even
if previous statement throws an exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Mesos resource manager unable to connect to master after failover
> -----------------------------------------------------------------
>
>                 Key: FLINK-9936
>                 URL: https://issues.apache.org/jira/browse/FLINK-9936
>             Project: Flink
>          Issue Type: Bug
>          Components: Mesos, Scheduler
>    Affects Versions: 1.5.0, 1.5.1, 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Renjie Liu
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.5.2, 1.6.0
>
>
> When deployed in mesos session cluster mode, the connector monitor keeps reporting unable
to connect to mesos after restart. In fact, scheduler driver already connected to mesos master,
but when the connected message is lost. This is because leadership is not granted yet and
fence id is not set, the rpc service ignores the connected message. So we should connect to
mesos master after leadership is granted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message