GitHub user snuyanzin opened a pull request:
https://github.com/apache/flink/pull/6263
[FLINK-9743][Client] Use correct zip/jar path separator
## What is the purpose of the change
*This PR resolves libraries extraction issue from jars*
## Brief change log
- *Always in case of zip/jar use '/' path separator*
- *Test with generated jar emulating the real case*
## Verifying this change
- Added test generates fake jar with a structure
test.jar
|- lib
|--|- internalTest.jar
and then calls for `PackagedProgram#extractContainedLibraries` to check if it extracts
internalTest.jar correctly
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/snuyanzin/flink FLINK_9743
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6263
----
commit 649b9f1a0893aea32bd2dc3cfa1702bfb77ab29f
Author: snuyanzin <snuyanzin@...>
Date: 2018-07-05T08:58:33Z
[FLINK-9743] use correct zip path separator,
PackagedProgramTest#testExtractContainedLibraries to check PackagedProgram#extractContainedLibraries
----
---
|