flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ubyyj <...@git.apache.org>
Subject [GitHub] flink pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscovere...
Date Sun, 15 Jul 2018 13:32:45 GMT
GitHub user ubyyj opened a pull request:

    https://github.com/apache/flink/pull/6336

    [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection …

    …leak on TopicAuthorizationException
    
    
    **(The sections below can be removed for hotfixes of typos)**
    
    ## What is the purpose of the change
    Fix the bug that Kafka09PartitionDiscoverer can cause TCP connection leak, if getAllPartitionsForTopics()
get a TopicAuthorizationException.
    
    ## Brief change log
    catch TopicAuthorizationException and close the kafkaConsumer in getAllPartitionsForTopics().
    
    ## Verifying this change
    This change added tests and can be verified as follows:
     - *Manually verified the change by running job which consumes from an non-exist kafka
topic, and verified the # of opened TCP connection and # file handle did not increase of the
task manager process, The fix has beening running in our production for weeks now, without
problem *
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ubyyj/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6336
    
----
commit 0aa8d75af085c2465e8cfd9e5a572770a5d95738
Author: yuanyoujun <yuanyoujun@...>
Date:   2018-07-15T13:07:49Z

    [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException

----


---

Mime
View raw message