From issues-return-179725-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Tue Jul 24 11:49:51 2018 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70DC818FE2 for ; Tue, 24 Jul 2018 11:49:51 +0000 (UTC) Received: (qmail 52878 invoked by uid 500); 24 Jul 2018 11:49:51 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 52805 invoked by uid 500); 24 Jul 2018 11:49:51 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 52729 invoked by uid 99); 24 Jul 2018 11:49:51 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2018 11:49:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D988ADFF06; Tue, 24 Jul 2018 11:49:50 +0000 (UTC) From: zentol To: issues@flink.apache.org Reply-To: issues@flink.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request #6399: [FLINK-5860] [tests] Replace java.io.tmpdir with J... Content-Type: text/plain Message-Id: <20180724114950.D988ADFF06@git1-us-west.apache.org> Date: Tue, 24 Jul 2018 11:49:50 +0000 (UTC) Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6399#discussion_r204722139 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/EnumerateNestedFilesTest.java --- @@ -240,36 +205,19 @@ public void testOnlyLevel2NestedDirectories() { */ @Test public void testTwoNestedDirectoriesWithFilteredFilesTrue() { - - String sep = System.getProperty("file.separator"); - try { String firstLevelDir = TestFileUtils.randomFileName(); String secondLevelDir = TestFileUtils.randomFileName(); String thirdLevelDir = TestFileUtils.randomFileName(); String secondLevelFilterDir = "_"+TestFileUtils.randomFileName(); String thirdLevelFilterDir = "_"+TestFileUtils.randomFileName(); - File nestedDir = new File(tempPath + sep + firstLevelDir); - nestedDir.mkdirs(); - nestedDir.deleteOnExit(); - - File insideNestedDir = new File(tempPath + sep + firstLevelDir + sep + secondLevelDir); - insideNestedDir.mkdirs(); - insideNestedDir.deleteOnExit(); - File insideNestedDirFiltered = new File(tempPath + sep + firstLevelDir + sep + secondLevelFilterDir); - insideNestedDirFiltered.mkdirs(); - insideNestedDirFiltered.deleteOnExit(); - File filteredFile = new File(tempPath + sep + firstLevelDir + sep + "_IWillBeFiltered"); - filteredFile.createNewFile(); - filteredFile.deleteOnExit(); - - File nestedNestedDir = new File(tempPath + sep + firstLevelDir + sep + secondLevelDir + sep + thirdLevelDir); - nestedNestedDir.mkdirs(); - nestedNestedDir.deleteOnExit(); - File nestedNestedDirFiltered = new File(tempPath + sep + firstLevelDir + sep + secondLevelDir + sep + thirdLevelFilterDir); - nestedNestedDirFiltered.mkdirs(); - nestedNestedDirFiltered.deleteOnExit(); + File nestedNestedDirFiltered = tempFolder.newFolder(firstLevelDir, secondLevelDir, thirdLevelDir, thirdLevelFilterDir); + File nestedNestedDir = nestedNestedDirFiltered.getParentFile(); + File insideNestedDir = nestedNestedDir.getParentFile(); + File nestedDir = insideNestedDir.getParentFile(); + File insideNestedDirFiltered = tempFolder.newFolder(firstLevelDir, secondLevelFilterDir); + new File(nestedDir, "_IWillBeFiltered"); --- End diff -- This file isn't explicitly created anymore. ---