[ https://issues.apache.org/jira/browse/FLINK-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544277#comment-16544277 ] 

ASF GitHub Bot commented on FLINK-8858:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6332#discussion_r202520618
  
    --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java ---
    @@ -329,14 +341,46 @@ public void stop(SessionContext session) {
     		}
     	}
     
    -	private <T> ResultDescriptor executeQueryInternal(ExecutionContext<T> context, String query) {
    +	private <C> ProgramTargetDescriptor executeUpdateInternal(ExecutionContext<C> context, String statement) {
    +		final ExecutionContext.EnvironmentInstance envInst = context.createEnvironmentInstance();
    +
    +		// apply update statement
    --- End diff --
    
    But there is no additional value of 
    ```
    // apply update statement
    ``` 
    over 
    ```
    applyUpdate(envInst.getTableEnvironment(), envInst.getQueryConfig(), statement);
    ```
    which is completely self explanatory. This is just form of some small code duplication. Same applies to most of those comments.


> Add support for INSERT INTO in SQL Client
> -----------------------------------------
>
>                 Key: FLINK-8858
>                 URL: https://issues.apache.org/jira/browse/FLINK-8858
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> The current design of SQL Client embedded mode doesn't support long running queries. It would be useful for simple jobs that can be expressed in a single sql statement if we can submit sql statements stored in files as long running queries. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)