From issues-return-174913-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Tue Jul 3 19:37:03 2018 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD946186D3 for ; Tue, 3 Jul 2018 19:37:03 +0000 (UTC) Received: (qmail 58703 invoked by uid 500); 3 Jul 2018 19:37:03 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 58666 invoked by uid 500); 3 Jul 2018 19:37:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 58657 invoked by uid 99); 3 Jul 2018 19:37:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jul 2018 19:37:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 250B518282C for ; Tue, 3 Jul 2018 19:37:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id GArWT6J01bFb for ; Tue, 3 Jul 2018 19:37:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0545B5F432 for ; Tue, 3 Jul 2018 19:37:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71EADE0CD1 for ; Tue, 3 Jul 2018 19:37:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 33E3C274FB for ; Tue, 3 Jul 2018 19:37:00 +0000 (UTC) Date: Tue, 3 Jul 2018 19:37:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9311) PubSub connector MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9311?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1653= 1854#comment-16531854 ]=20 ASF GitHub Bot commented on FLINK-9311: --------------------------------------- GitHub user Xeli opened a pull request: https://github.com/apache/flink/pull/6248 [FLINK-9311] [pubsub] Added PubSub connector with support for checkpoin= ting ## What is the purpose of the change =20 Adding a PubSub connector with support for Checkpointing =20 ## Verifying this change =20 This change added tests and can be verified as follows: =20 - *Added unit tests* - *Manually verified the connector (without Checkpointing) on an actua= l PubSub topic and subscription.* **Is there a need for integration tests? I did not see any for the othe= r connectors.=20 What is a good way of testing the checkpointing / exactly-once behavior= ?** =20 ## Does this pull request potentially affect one of the following parts= : =20 - Dependencies (does it add or upgrade a dependency): yes, Google Clo= ud Sdk for PubSub (**Does this need to be shaded?**) - The public API, i.e., is any changed class annotated with `@Public(= Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): don't kn= ow, don't think so - Anything that affects deployment or recovery: JobManager (and its c= omponents), Checkpointing, Yarn/Mesos, ZooKeeper: yes, checkpointing - The S3 file system connector: no =20 ## Documentation =20 - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? JavaDocs You can merge this pull request into a Git repository by running: $ git pull https://github.com/Xeli/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6248 =20 ---- commit dddbe671a0d663045110b89ad9bb85ce9a7e7051 Author: Richard Deurwaarder Date: 2018-05-26T12:59:32Z [FLINK-9311] [pubsub] Add PubSubSource without checkpointing commit 30fab0fd6810691f22ff583ce3f942e247d9fe45 Author: Richard Deurwaarder Date: 2018-07-03T17:34:02Z [FLINK-9311] [pubsub] Add checkpointing to PubSubSource ---- > PubSub connector > ---------------- > > Key: FLINK-9311 > URL: https://issues.apache.org/jira/browse/FLINK-9311 > Project: Flink > Issue Type: New Feature > Components: Streaming Connectors > Reporter: Richard Deurwaarder > Priority: Minor > Labels: pull-request-available > > I would like start adding some google cloud connectors starting with a Pu= bSub Source. I have a basic implementation ready but I want it to be able t= o: > * easily scale up (should I have it extend RichParallelSourceFunction fo= r this?) > * Make it easier to provide the google cloud credentials. This would req= uire being able to send some json string / ServiceAccount to the nodes when= starting up this source. > Could=C2=A0this be something that would be useful for others and added to= the flink connectors repo? -- This message was sent by Atlassian JIRA (v7.6.3#76005)