From issues-return-174304-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Mon Jul 2 10:00:04 2018 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06EE5179F2 for ; Mon, 2 Jul 2018 10:00:04 +0000 (UTC) Received: (qmail 93175 invoked by uid 500); 2 Jul 2018 10:00:03 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 93137 invoked by uid 500); 2 Jul 2018 10:00:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 93128 invoked by uid 99); 2 Jul 2018 10:00:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2018 10:00:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3F569C0040 for ; Mon, 2 Jul 2018 10:00:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id cPoMHHpp92Pk for ; Mon, 2 Jul 2018 10:00:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7247D5F57D for ; Mon, 2 Jul 2018 10:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B2329E0DAA for ; Mon, 2 Jul 2018 10:00:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7216321832 for ; Mon, 2 Jul 2018 10:00:00 +0000 (UTC) Date: Mon, 2 Jul 2018 10:00:00 +0000 (UTC) From: "Nico Kruber (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (FLINK-9636) Network buffer leaks in requesting a batch of segments during canceling MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9636?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1652= 9613#comment-16529613 ]=20 Nico Kruber edited comment on FLINK-9636 at 7/2/18 9:59 AM: ------------------------------------------------------------ Actually, {{numRequiredBuffers}} is only a local variable in this method - = why should we bother changing it? Also, if there is an {{InterruptedException}} when polling memory segments = from the {{availableMemorySegments}} queue, this will be re-thrown and the = request will fail - {{NetworkBufferPool}} should then be restored to the st= ate it was before which it is, isn't it? I see only one point where the accounting for {{numTotalRequiredBuffers}} c= an be wrong: if an exception is thrown in the first of the {{redistributeBu= ffers()}} calls. Tracing it further down, this can only happen if {{Spillab= leSubpartition#releaseMemory()}} throws, e.g. due to a failure in creating = a {{spillWriter}}. I'm working on a patch... was (Author: nicok): Actually, {{numRequiredBuffers}} is only a local variable in this method - = why should we bother changing it? Also, if there is an {{InterruptedException}} when polling memory segments = from the {{availableMemorySegments}} queue, this will be re-thrown and the = request will fail - {{NetworkBufferPool}} should then be restored to the st= ate it was before which it is, isn't it? I see only one point where the accounting for {{numTotalRequiredBuffers}} c= an be wrong: if an exception is thrown in the first of the {{redistributeBu= ffers()}} calls. > Network buffer leaks in requesting a batch of segments during canceling > ----------------------------------------------------------------------- > > Key: FLINK-9636 > URL: https://issues.apache.org/jira/browse/FLINK-9636 > Project: Flink > Issue Type: Bug > Components: Network > Affects Versions: 1.5.0, 1.6.0 > Reporter: zhijiang > Priority: Major > Fix For: 1.5.1 > > > In {{NetworkBufferPool#requestMemorySegments}},=C2=A0{{numTotalRequiredBu= ffers}} is increased by {{numRequiredBuffers}} first. > If=C2=A0{{InterruptedException}}=C2=A0is thrown during polling segments f= rom the available queue, the requested segments will be recycled back to {{= NetworkBufferPool}},=C2=A0{{numTotalRequiredBuffers}} is decreased by the n= umber=C2=A0of polled segments which is now inconsistent with {{numRequiredB= uffers}}. So {{numTotalRequiredBuffers}}=C2=A0in {{NetworkBufferPool}}=C2= =A0leaks in this case, and we can also decrease {{numRequiredBuffers}} to= =C2=A0fix this bug. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)