From issues-return-175009-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Wed Jul 4 09:14:03 2018 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 364AF17465 for ; Wed, 4 Jul 2018 09:14:03 +0000 (UTC) Received: (qmail 49604 invoked by uid 500); 4 Jul 2018 09:14:03 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 49569 invoked by uid 500); 4 Jul 2018 09:14:03 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 49560 invoked by uid 99); 4 Jul 2018 09:14:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jul 2018 09:14:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id ABDCAC00A7 for ; Wed, 4 Jul 2018 09:14:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id byoQMlU8J7t1 for ; Wed, 4 Jul 2018 09:14:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9BE6B5F19D for ; Wed, 4 Jul 2018 09:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D833AE00A7 for ; Wed, 4 Jul 2018 09:14:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 26E4C2750A for ; Wed, 4 Jul 2018 09:14:00 +0000 (UTC) Date: Wed, 4 Jul 2018 09:14:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9718) Add enviroment variable in start-scala-shell.sh to enable remote debug MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532505#comment-16532505 ] ASF GitHub Bot commented on FLINK-9718: --------------------------------------- Github user zjffdu commented on a diff in the pull request: https://github.com/apache/flink/pull/6245#discussion_r200060027 --- Diff: flink-scala-shell/start-script/start-scala-shell.sh --- @@ -19,6 +19,9 @@ # from scala-lang 2.10.4 +# Uncomment the following line to enable remote debug +# export FLINK_SCALA_SHELL_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=5005" --- End diff -- Sorry @yanghua I still think using bool flag is not proper. Regarding `hiding the details of remote debug info`, I mean bool flag only control whether to enable remote debug, but does't control how, such as which port to listen. If we introduce this bool flag, we will use 2 env variable to control whether and how to remote debug which is too verbose to me. > Add enviroment variable in start-scala-shell.sh to enable remote debug > ---------------------------------------------------------------------- > > Key: FLINK-9718 > URL: https://issues.apache.org/jira/browse/FLINK-9718 > Project: Flink > Issue Type: Improvement > Reporter: Jeff Zhang > Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian JIRA (v7.6.3#76005)