From issues-return-177042-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Thu Jul 12 14:06:03 2018 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D81D18CB3 for ; Thu, 12 Jul 2018 14:06:03 +0000 (UTC) Received: (qmail 60412 invoked by uid 500); 12 Jul 2018 14:06:03 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 60376 invoked by uid 500); 12 Jul 2018 14:06:02 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 60362 invoked by uid 99); 12 Jul 2018 14:06:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jul 2018 14:06:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 5D11EC0420 for ; Thu, 12 Jul 2018 14:06:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id BtPpc2p8NpJX for ; Thu, 12 Jul 2018 14:06:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 2E82E5F35A for ; Thu, 12 Jul 2018 14:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6C35EE0D09 for ; Thu, 12 Jul 2018 14:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2821F23F9A for ; Thu, 12 Jul 2018 14:06:00 +0000 (UTC) Date: Thu, 12 Jul 2018 14:06:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-9799) Generalize/unify state meta info MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-9799?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1654= 1693#comment-16541693 ]=20 ASF GitHub Bot commented on FLINK-9799: --------------------------------------- Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6308#discussion_r202047403 =20 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/Se= rializationProxiesTest.java --- @@ -126,11 +131,11 @@ public void testKeyedBackendSerializationProxyRou= ndtripWithSerializerSerializati =09=09Assert.assertTrue(serializationProxy.getKeySerializer() instance= of UnloadableDummyTypeSerializer); =09=09Assert.assertEquals(keySerializer.snapshotConfiguration(), seria= lizationProxy.getKeySerializerConfigSnapshot()); =20 -=09=09for (RegisteredKeyedBackendStateMetaInfo.Snapshot meta : s= erializationProxy.getStateMetaInfoSnapshots()) { -=09=09=09Assert.assertTrue(meta.getNamespaceSerializer() instanceof Un= loadableDummyTypeSerializer); -=09=09=09Assert.assertTrue(meta.getStateSerializer() instanceof Unload= ableDummyTypeSerializer); -=09=09=09Assert.assertEquals(namespaceSerializer.snapshotConfiguration= (), meta.getNamespaceSerializerConfigSnapshot()); -=09=09=09Assert.assertEquals(stateSerializer.snapshotConfiguration(), = meta.getStateSerializerConfigSnapshot()); +=09=09for (StateMetaInfoSnapshot meta : serializationProxy.getStateMet= aInfoSnapshots()) { --- End diff -- =20 =F0=9F=91=8D Good point > Generalize/unify state meta info > -------------------------------- > > Key: FLINK-9799 > URL: https://issues.apache.org/jira/browse/FLINK-9799 > Project: Flink > Issue Type: Sub-task > Components: State Backends, Checkpointing > Affects Versions: 1.5.0 > Reporter: Stefan Richter > Assignee: Stefan Richter > Priority: Major > Labels: pull-request-available > > Flink currently has a couple of classes that describe the meta data of st= ate (e.g. for keyed state, operator state, broadcast state, ...) and they t= ypically come with their own serialization proxy and backwards compatibilit= y story. However, the differences between those meta data classes are very = small, like different option flags and a different set of serializers. Befo= re introducing yet another meta data for timers, we should unify them in a = general state meta data class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)