From issues-return-177772-apmail-flink-issues-archive=flink.apache.org@flink.apache.org Sun Jul 15 13:32:45 2018 Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA9D21812C for ; Sun, 15 Jul 2018 13:32:45 +0000 (UTC) Received: (qmail 23972 invoked by uid 500); 15 Jul 2018 13:32:45 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 23926 invoked by uid 500); 15 Jul 2018 13:32:45 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 23917 invoked by uid 99); 15 Jul 2018 13:32:45 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jul 2018 13:32:45 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 575A9DFF73; Sun, 15 Jul 2018 13:32:45 +0000 (UTC) From: ubyyj To: issues@flink.apache.org Reply-To: issues@flink.apache.org Message-ID: Subject: [GitHub] flink pull request #6336: [FLINK-9630] [connector] Kafka09PartitionDiscovere... Content-Type: text/plain Date: Sun, 15 Jul 2018 13:32:45 +0000 (UTC) GitHub user ubyyj opened a pull request: https://github.com/apache/flink/pull/6336 [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection … …leak on TopicAuthorizationException **(The sections below can be removed for hotfixes of typos)** ## What is the purpose of the change Fix the bug that Kafka09PartitionDiscoverer can cause TCP connection leak, if getAllPartitionsForTopics() get a TopicAuthorizationException. ## Brief change log catch TopicAuthorizationException and close the kafkaConsumer in getAllPartitionsForTopics(). ## Verifying this change This change added tests and can be verified as follows: - *Manually verified the change by running job which consumes from an non-exist kafka topic, and verified the # of opened TCP connection and # file handle did not increase of the task manager process, The fix has beening running in our production for weeks now, without problem * ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ubyyj/flink master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/6336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6336 ---- commit 0aa8d75af085c2465e8cfd9e5a572770a5d95738 Author: yuanyoujun Date: 2018-07-15T13:07:49Z [FLINK-9630] [connector] Kafka09PartitionDiscoverer cause connection leak on TopicAuthorizationException ---- ---