flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tzulitai commented on a change in pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch 6.x
Date Wed, 01 Aug 2018 05:45:42 GMT
tzulitai commented on a change in pull request #6391: [FLINK-9885] [FLINK-8101] Finalize Elasticsearch
6.x
URL: https://github.com/apache/flink/pull/6391#discussion_r206760543
 
 

 ##########
 File path: flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/ElasticsearchSink.java
 ##########
 @@ -97,6 +97,15 @@ public Builder(List<HttpHost> httpHosts, ElasticsearchSinkFunction<T>
elasticsea
 			this.elasticsearchSinkFunction = Preconditions.checkNotNull(elasticsearchSinkFunction);
 		}
 
+		/**
+		 * Sets a map of strings that configures the bulk flushing behaviour.
+		 *
+		 * @param bulkRequestsConfig user configuration to configure bulk flushing behaviour.
+		 */
+		public void setBulkRequestsConfig(Map<String, String> bulkRequestsConfig) {
+			this.bulkRequestsConfig = bulkRequestsConfig;
 
 Review comment:
   My thought was just that it's more or less a convenience for users. In some scenarios,
having a properties like setter would be easier to use. I'm completely ok with removing it,
though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message