flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] florianschmidt1994 commented on a change in pull request #6453: [FLINK-9874][E2E Tests] Fix set_ssl_conf for macOS
Date Wed, 01 Aug 2018 09:30:01 GMT
florianschmidt1994 commented on a change in pull request #6453: [FLINK-9874][E2E Tests] Fix
set_ssl_conf for macOS
URL: https://github.com/apache/flink/pull/6453#discussion_r206812468
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/common.sh
 ##########
 @@ -154,12 +175,15 @@ function set_conf_ssl {
        rm -rf "${TEST_DATA_DIR}/ssl"
     fi
     mkdir -p "${TEST_DATA_DIR}/ssl"
+
     NODENAME=`hostname -f`
     SANSTRING="dns:${NODENAME}"
-    for NODEIP in `hostname -I | cut -d' ' -f1` ; do
+    for NODEIP in $(get_node_ip) ; do
 
 Review comment:
   `hostname -I ` would return a list of IP addresses separated by a space, and the cut would
only select one of those. The intended behaviour according to my discussion with @NicoK is
that we append all IP addresses returned by `hostname -I` to the SANSTRING, which is why I
removed that line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message