flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function for table/sql API
Date Thu, 02 Aug 2018 04:36:41 GMT
yanghua commented on a change in pull request #6432: [FLINK-9970] [table] Add ASCII/CHR function
for table/sql API
URL: https://github.com/apache/flink/pull/6432#discussion_r207099504
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
 ##########
 @@ -146,12 +146,25 @@ object FunctionGenerator {
     STRING_TYPE_INFO,
     BuiltInMethod.OVERLAY.method)
 
+  addSqlFunctionMethod(
+    ASCII,
+    Seq(STRING_TYPE_INFO),
+    STRING_TYPE_INFO,
 
 Review comment:
   @hequn8128 yes, I agree this point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message