flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tzulitai commented on a change in pull request #6467: [FLINK-9887] Ensure serializer upgrades work with timer service remake
Date Thu, 02 Aug 2018 09:47:46 GMT
tzulitai commented on a change in pull request #6467: [FLINK-9887] Ensure serializer upgrades
work with timer service remake
URL: https://github.com/apache/flink/pull/6467#discussion_r207163024
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimeServiceManager.java
 ##########
 @@ -46,12 +46,11 @@
 @Internal
 public class InternalTimeServiceManager<K> {
 
-	//TODO guard these constants with a test
-	private static final String TIMER_STATE_PREFIX = "_timer_state";
-	private static final String PROCESSING_TIMER_PREFIX = TIMER_STATE_PREFIX + "/processing_";
-	private static final String EVENT_TIMER_PREFIX = TIMER_STATE_PREFIX + "/event_";
 
-	private final int totalKeyGroups;
+	static final String TIMER_STATE_PREFIX = "_timer_state";
 
 Review comment:
   Add `@VisibleForTesting` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message