flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP
Date Fri, 03 Aug 2018 07:25:21 GMT
GJL commented on a change in pull request #6464: [FLINK-9936][mesos] WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207461579
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -278,22 +267,76 @@ protected void initialize() throws ResourceManagerException {
 		catch (IOException e) {
 			throw new ResourceManagerException("Unable to configure the artifact server with TaskManager
artifacts.", e);
 		}
+	}
 
-		// begin scheduling
-		connectionMonitor.tell(new ConnectionMonitor.Start(), selfActor);
-		schedulerDriver.start();
+	@Override
+	protected CompletableFuture<Void> prepareLeadershipAsync() {
+		Preconditions.checkState(initializedMesosConfig != null);
+
+		return clearStateFuture
+			.thenRunAsync(() -> {
+				schedulerDriver = initializedMesosConfig.createDriver(
+					new MesosResourceManagerSchedulerCallback(),
+					false);
+
+				// create supporting actors
+				connectionMonitor = createConnectionMonitor();
+				launchCoordinator = createLaunchCoordinator(schedulerDriver, selfActor);
+				reconciliationCoordinator = createReconciliationCoordinator(schedulerDriver);
+				taskMonitor = createTaskMonitor(schedulerDriver);
+			}, getMainThreadExecutor())
+			.thenCombineAsync(getWorkersAsync(), (ignored, tasksFromPreviousAttempts) -> {
+				// recover state
+				recoverWorkers(tasksFromPreviousAttempts);
+
+				// begin scheduling
+				connectionMonitor.tell(new ConnectionMonitor.Start(), selfActor);
+				schedulerDriver.start();
+
+				LOG.info("Mesos resource manager started.");
+				return null;
+			}, getMainThreadExecutor());
+	}
 
-		LOG.info("Mesos resource manager initialized.");
+	@Override
+	protected void clearState() {
+		schedulerDriver.stop(true);
+
+		clearStateFuture = stopSupportingActorsAsync().thenRunAsync(() -> {
+			workersInNew.clear();
+			workersInLaunch.clear();
+			workersBeingReturned.clear();
 
 Review comment:
   That should be safe to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message