flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] azagrebin commented on a change in pull request #6460: [FLINK-9938] Clean up full snapshot from expired state with TTL
Date Fri, 03 Aug 2018 14:38:21 GMT
azagrebin commented on a change in pull request #6460: [FLINK-9938] Clean up full snapshot
from expired state with TTL
URL: https://github.com/apache/flink/pull/6460#discussion_r207566014
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTableSnapshot.java
 ##########
 @@ -217,12 +223,29 @@ protected void reportAllElementKeyGroups() {
 			int flattenIndex = 0;
 			for (CopyOnWriteStateTable.StateTableEntry<K, N, S> entry : partitioningDestination)
{
 				while (null != entry) {
-					final int keyGroup = KeyGroupRangeAssignment.assignToKeyGroup(entry.key, totalKeyGroups);
-					reportKeyGroupOfElementAtIndex(flattenIndex, keyGroup);
-					partitioningSource[flattenIndex++] = entry;
+					CopyOnWriteStateTable.StateTableEntry<K, N, S> filteredEntry = filterEntry(entry);
 
 Review comment:
   I think we can extend this class with filtering and use extension only if there is an actual
filter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message