flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dawidwys commented on a change in pull request #6259: [FLINK-9679] Implement AvroSerializationSchema
Date Tue, 07 Aug 2018 10:00:24 GMT
dawidwys commented on a change in pull request #6259: [FLINK-9679] Implement AvroSerializationSchema
URL: https://github.com/apache/flink/pull/6259#discussion_r208169106
 
 

 ##########
 File path: flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/ConfluentSchemaRegistryCoder.java
 ##########
 @@ -64,4 +81,19 @@ public Schema readSchema(InputStream in) throws IOException {
 		}
 	}
 
+	@Override
+	public byte[] writeSchema(Class tClass, ByteArrayOutputStream out) throws IOException {
 
 Review comment:
   The return value is unnecessary. Return `void` from this function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message