flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] hequn8128 commented on a change in pull request #6521: [FLINK-5315][table] Adding support for distinct operation for table API on DataStream
Date Wed, 08 Aug 2018 11:47:29 GMT
hequn8128 commented on a change in pull request #6521: [FLINK-5315][table] Adding support for
distinct operation for table API on DataStream
URL: https://github.com/apache/flink/pull/6521#discussion_r208549936
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/table/validation/AggregateValidationTest.scala
 ##########
 @@ -21,11 +21,24 @@ package org.apache.flink.table.api.stream.table.validation
 import org.apache.flink.api.scala._
 import org.apache.flink.table.api.ValidationException
 import org.apache.flink.table.api.scala._
+import org.apache.flink.table.runtime.utils.JavaUserDefinedAggFunctions.WeightedAvg
 import org.apache.flink.table.utils.TableTestBase
 import org.junit.Test
 
 class AggregateValidationTest extends TableTestBase {
 
+  @Test(expected = classOf[ValidationException])
+  def testDistinctModifierOnBothSide(): Unit = {
+    val util = streamTestUtil()
+    val table = util.addTable[(Long, Int, String)]('a, 'b, 'c)
+    val func = new WeightedAvg
+
+    val ds = table
+      // must fail. '_foo is not a valid field
 
 Review comment:
   Adapt this comment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message