flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] hequn8128 commented on issue #6519: [FLINK-9559] [table] The type of a union of CHAR columns of different lengths should be VARCHAR
Date Wed, 08 Aug 2018 15:21:05 GMT
hequn8128 commented on issue #6519: [FLINK-9559] [table] The type of a union of CHAR columns
of different lengths should be VARCHAR
URL: https://github.com/apache/flink/pull/6519#issuecomment-411444753
 
 
   @twalthr Thanks a lot for your review. You are right. This change will break implementations
and we should be careful. 
   From my point of view, we don't need to make it configurable. Mysql return varchar directly,
[see](https://dev.mysql.com/doc/refman/8.0/en/control-flow-functions.html), "If all types
are character string (CHAR or VARCHAR), the result is VARCHAR with maximum length determined
by the longest character length of the operands.".
   Of course, it is ok to make it configurable if you both think yes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message