flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] walterddr commented on a change in pull request #6425: [FLINK-9664][Doc] fixing documentation in ML quick start
Date Wed, 08 Aug 2018 15:32:41 GMT
walterddr commented on a change in pull request #6425: [FLINK-9664][Doc] fixing documentation
in ML quick start
URL: https://github.com/apache/flink/pull/6425#discussion_r208629086
 
 

 ##########
 File path: docs/dev/libs/ml/quickstart.md
 ##########
 @@ -129,6 +129,10 @@ and the [test set here](http://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/b
 This is an astroparticle binary classification dataset, used by Hsu et al. [[3]](#hsu) in
their
 practical Support Vector Machine (SVM) guide. It contains 4 numerical features, and the class
label.
 
+Before importing the traning and test dataset, Flink SVM only supports threshold binary values
of 
+`+1.0` and `-1.0`. Thus a conversion is needed upon downloading the svmguide1 dataset since
it is 
+labelled using `1`s and `0`s.
+
 
 Review comment:
   I see. if i understand correctly, summary of the suggestions are:
   1. move the explanation of why -1.0 and +1.0 to classification page. 
   2. leave the quickstart section clean by adding an explicit conversion from 0,1 to -1,1
so that copy-paste will work. and do not expand too much into why -1,+1 is needed, just mentioned
that's needed.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message