flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zentol commented on a change in pull request #6529: [FLINK-10106][e2e] Included test name in temp directory of e2e test
Date Thu, 09 Aug 2018 09:14:14 GMT
zentol commented on a change in pull request #6529: [FLINK-10106][e2e] Included test name in
temp directory of e2e test
URL: https://github.com/apache/flink/pull/6529#discussion_r208858966
 
 

 ##########
 File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
 ##########
 @@ -29,12 +29,14 @@ function run_test {
     description="$1"
     command="$2"
 
+    name=$(basename "${command}" | sed -e 's/[_ ]/-/g' | sed -n 's/\.sh//p')
 
 Review comment:
   why not base it on the description instead? This should be more informative as the script
is shared for multiple tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message