flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] twalthr commented on a change in pull request #6359: [FLINK-6895][table]Add STR_TO_DATE supported in SQL
Date Mon, 13 Aug 2018 12:28:22 GMT
twalthr commented on a change in pull request #6359: [FLINK-6895][table]Add STR_TO_DATE supported
in SQL
URL: https://github.com/apache/flink/pull/6359#discussion_r209589672

 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/StrToDateCallGen.scala
 @@ -0,0 +1,48 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.codegen.calls
+import org.apache.flink.api.common.typeinfo.SqlTimeTypeInfo
+import org.apache.flink.table.codegen.calls.CallGenerator.generateCallIfArgsNotNull
+import org.apache.flink.table.codegen.{CodeGenerator, GeneratedExpression}
+import org.apache.flink.table.runtime.functions.DateTimeFunctions
+  * Generates StrToDate call based on the type of last operand.
+  */
+class StrToDateCallGen extends CallGenerator {
+  override def generate(codeGenerator: CodeGenerator,
+                        operands: Seq[GeneratedExpression]): GeneratedExpression = {
+    if (operands.last.literal) {
 Review comment:
   @buptljy Yes, I meant something like a `literalValue` for `GeneratedExpression` or sth.
more object-oriented. A `LiteralExpression` that extends `GeneratedExpression`. However, before
we do this. We need to make sure that Calcite supports this function. We cannot return a different
type as Calcite. We need to stay in sync with Calcite's type system otherwise we get a type
mismatch in following operators. So first we should explore if Calcite supports this functions
with its operand type/return type inference logic.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message