flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file
Date Mon, 13 Aug 2018 17:03:03 GMT
zentol commented on issue #6542: [FLINK-6437][History Server] Move history server configuration
to a separate file
URL: https://github.com/apache/flink/pull/6542#issuecomment-412590513
 
 
   That strategy is already implemented, but it doesn't really address backwards compatibility
imo. I would assume that when people upgrade they'll end up with the default `flink-historyserver-conf.yaml`
being present in `conf` overwriting everything in `flink-conf.yaml`.
   
   We could comment out everything in in the HS config file, always read both and prioritize
contents in the HS config. This wouldn't affect old users (we could also guide them with logging
messages if settings are found in `flink-conf.yaml`, nor should it affect new users as either
a) they have to set a key anyway or b) a sane default handles this case.
   
   Still, I'm wondering whether there's really a benefit here. If we start splitting config
files I'd prefer if we'd to the same for the client.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message