flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] NicoK commented on issue #6355: [FLINK-9878][network][ssl] add more low-level ssl options
Date Mon, 13 Aug 2018 17:25:42 GMT
NicoK commented on issue #6355: [FLINK-9878][network][ssl] add more low-level ssl options
URL: https://github.com/apache/flink/pull/6355#issuecomment-412597634
   I pushed a rework of this PR which has a lighter footprint on the changes in SSLUtils by
using a wrapper around `SSLContext` as @pnowojski suggested.
   I kept all existing logic though, including the `@Nullable` fields (vs. `Optional`) for
these reasons:
   1) there are already conflicts when applying this to `release-1.6` and I'd like to keep
the footprint small (some of the suggestions already make the diff bigger)
   2) there are several `null` checks which would need refactoring
   3) this seems to be out of scope of this PR, especially since no nullable field is added
(any more)

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message