flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] yanghua edited a comment on issue #6542: [FLINK-6437][History Server] Move history server configuration to a separate file
Date Tue, 14 Aug 2018 02:46:19 GMT
yanghua edited a comment on issue #6542: [FLINK-6437][History Server] Move history server configuration
to a separate file
URL: https://github.com/apache/flink/pull/6542#issuecomment-412736043
 
 
   hi @StephanEwen @zentol ,
   
   Currently, the history server runs as a single JVM process, which means it is a separate
component. I think the configuration split is reasonable. If I only need to start the history
server then I don't rely on other configurations, and I don't need to pay attention to other
configurations.
   
   Regarding the discussion of compatibility, I basically agree with @zentol  's point of
view.
   
   Basic on the existing implementation, I think we can add more log warnings in the new method
of `GlobalConfiguration`. The general idea is as follows:
   
   * Judge the new configuration file, if it does not exist, I will add a log to inform the
user that he is using the old configuration;
   * If the new configuration and the old configuration about history server exist at the
same time,  then we will warn the user that there are two configurations and we will base
on the `flink-historyserver-conf.yaml`;
   
   In addition, I will give a log warning when the configuration file is loaded by the `HistoryServer#main`
method, for example : 
   
   > the current configuration about history server in `flink-conf.yaml` is only for backward
compatibility, it is recommended that they enable the new configuration file `flink-historyserver-conf.yaml`.
   
   In addition, I will comment out the configuration items in the `flink-historyserver-conf.yaml`,
considering that we have done so many guides, I believe users will be more likely to accept
the correct guidelines.
   
   Even if it is based on a configuration already in `flink-conf.yaml`, the current implementation
will still work. But if we say that there are configurations in both files, we seem to have
no better way than to give a warning "based on `flink-historyserver-conf.yaml`".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message