flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] azagrebin commented on a change in pull request #6425: [FLINK-9664][Doc] fixing documentation in ML quick start
Date Tue, 14 Aug 2018 10:08:38 GMT
azagrebin commented on a change in pull request #6425: [FLINK-9664][Doc] fixing documentation
in ML quick start
URL: https://github.com/apache/flink/pull/6425#discussion_r209897278
 
 

 ##########
 File path: docs/dev/libs/ml/quickstart.md
 ##########
 @@ -146,7 +145,23 @@ create a classifier.
 
 ## Classification
 
-Once we have imported the dataset we can train a `Predictor` such as a linear SVM classifier.
+After importing the training and test dataset, they need to be prepared for the classification.

+Because Flink SVM only supports threshold binary values of `+1.0` and `-1.0`, a conversion
is 
+needed after loading the LibSVM dataset since it is labelled using `1`s and `0`s.
 
 Review comment:
   Just a wording thing, I would swap `Because` and `since` in this sentence:
   **Since** Flink SVM only supports threshold binary values of `+1.0` and `-1.0`, a conversion
is 
   needed after loading the LibSVM dataset **because** it is labelled using `1`s and `0`s.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message