flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] bowenli86 commented on issue #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer
Date Tue, 21 Aug 2018 00:53:21 GMT
bowenli86 commented on issue #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone
in DateTimeBucketer
URL: https://github.com/apache/flink/pull/6492#issuecomment-414513166
 
 
   @kl0u  a couple things that may need attention:
   
   - powerMock needs to stay in order to mock static method `ZoneId.systemDefault()`. Didn't
find a better way to mock static method with Mockito other than using PowerMockito. I believe
what we have now should be fine.
   - `SimpleDateFormat` doesn't take java8's new `LocalDateTime`, so have to change formatter
to `DateTimeFormatter`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message