flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] xccui commented on a change in pull request #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL
Date Tue, 21 Aug 2018 02:16:40 GMT
xccui commented on a change in pull request #6576: [FLINK-10145][table] Add replace supported
in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6576#discussion_r211457188
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
 ##########
 @@ -459,6 +459,15 @@ trait ImplicitExpressionOperations {
     }
   }
 
+  /**
+    * Create a new string of the given string with non-overlapping occurrences
 
 Review comment:
   Use singular for docs here (Create -> Creates).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message