flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Guibo-Pan commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI and SQL
Date Tue, 21 Aug 2018 06:32:50 GMT
Guibo-Pan commented on issue #6576: [FLINK-10145][table] Add replace supported in TableAPI
and SQL
URL: https://github.com/apache/flink/pull/6576#issuecomment-414564921
 
 
   Thanks for your patient review, @xccui . I have update the docs and styles.
   
   I am not so familiar with `CodeGenerator` so far. At the comment you said:
   > in SQL convention, any null argument will lead to a null result. Thus when generating
a scalar function call, all the arguments (expressions) will be first checked to ensure not
null
   
   I did make some test cases on null inputs, it seems that the builtin `replace` can not
pass. So I change the builtin `replace` to my `replace` in commit b262a4.
   I think maybe something is misunderstand by me, can you give me more guidance to help me
understand it? Thanks.
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message