flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8354) Flink Kafka connector ignores Kafka message headers
Date Mon, 27 Aug 2018 16:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593905#comment-16593905
] 

ASF GitHub Bot commented on FLINK-8354:
---------------------------------------

yanghua commented on a change in pull request #6615: [FLINK-8354] [flink-connectors] Add ability
to access and provider Kafka headers
URL: https://github.com/apache/flink/pull/6615#discussion_r213034632
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/util/serialization/KeyedDeserializationSchema.java
 ##########
 @@ -54,4 +55,20 @@
 	 * @return True, if the element signals end of stream, false otherwise.
 	 */
 	boolean isEndOfStream(T nextElement);
+
+	/**
+	 * Deserializes the byte message.
+	 *
+	 * @param messageKey the key as a byte array (null if no key has been set).
+	 * @param message The message, as a byte array (null if the message was empty or deleted).
 
 Review comment:
   missed topic parameter description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Flink Kafka connector ignores Kafka message  headers 
> -----------------------------------------------------
>
>                 Key: FLINK-8354
>                 URL: https://issues.apache.org/jira/browse/FLINK-8354
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>         Environment: Kafka 0.11.0.0
> Flink 1.4.0
> flink-connector-kafka-0.11_2.11 
>            Reporter: Mohammad Abareghi
>            Assignee: Aegeaner
>            Priority: Major
>              Labels: pull-request-available
>
> Kafka has introduced notion of Header for messages in version 0.11.0.0  https://issues.apache.org/jira/browse/KAFKA-4208.
> But flink-connector-kafka-0.11_2.11 which supports kafka 0.11.0.0 ignores headers when
consuming kafka messages. 
> It would be useful in some scenarios, such as distributed log tracing, to support message
headers to FlinkKafkaConsumer011 and FlinkKafkaProducer011. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message