flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17
Date Sat, 04 Aug 2018 07:24:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569110#comment-16569110
] 

ASF GitHub Bot commented on FLINK-9134:
---------------------------------------

suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite
dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207702177
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/GroupWindowTest.scala
 ##########
 @@ -161,7 +161,7 @@ class GroupWindowTest extends TableTestBase {
             "rowtime('w$) AS w$rowtime",
             "proctime('w$) AS w$proctime")
         ),
-        term("select", "EXPR$0", "DATETIME_PLUS(w$end, 60000) AS EXPR$1")
+        term("select", "EXPR$0", "+(w$end, 60000) AS EXPR$1")
 
 Review comment:
   This is changed in https://issues.apache.org/jira/browse/CALCITE-2188. DATETIME_PLUS operator
is not equal to PLUS operator, they just somehow share the same name "+" in plan after the
PR. I can reach out to Calcite community to see if it makes sense to revert it back, I agree
that using "DATETIME_PLUS" is more clear. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update Calcite dependency to 1.17
> ---------------------------------
>
>                 Key: FLINK-9134
>                 URL: https://issues.apache.org/jira/browse/FLINK-9134
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Shuyi Chen
>            Priority: Major
>              Labels: pull-request-available
>
> This is an umbrella issue for tasks that need to be performed when upgrading to Calcite
1.17 once it is released.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message