flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17
Date Fri, 03 Aug 2018 16:15:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568425#comment-16568425
] 

ASF GitHub Bot commented on FLINK-9134:
---------------------------------------

TisonKun commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite
dependency to 1.17
URL: https://github.com/apache/flink/pull/6484#discussion_r207595810
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/GroupWindowTest.scala
 ##########
 @@ -161,7 +161,7 @@ class GroupWindowTest extends TableTestBase {
             "rowtime('w$) AS w$rowtime",
             "proctime('w$) AS w$proctime")
         ),
-        term("select", "EXPR$0", "DATETIME_PLUS(w$end, 60000) AS EXPR$1")
+        term("select", "EXPR$0", "+(w$end, 60000) AS EXPR$1")
 
 Review comment:
   @twalthr code relevant is around `CodeGenerator#L769` and I think `+` is equivalent to
`DATETIME_PLUS` here and below.
   However, I see no reason for this change. Not only `DATETIME_PLUS` works as expected, but
also `DATETIME_PLUS` is more clear than bare `+`. How can one know `(w$end, 60000)` is about
`DATETIME` without take a near look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update Calcite dependency to 1.17
> ---------------------------------
>
>                 Key: FLINK-9134
>                 URL: https://issues.apache.org/jira/browse/FLINK-9134
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Shuyi Chen
>            Priority: Major
>              Labels: pull-request-available
>
> This is an umbrella issue for tasks that need to be performed when upgrading to Calcite
1.17 once it is released.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message