flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9231) Enable SO_REUSEADDR on listen sockets
Date Thu, 09 Aug 2018 11:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574734#comment-16574734

ASF GitHub Bot commented on FLINK-9231:

tillrohrmann closed pull request #5920: [FLINK-9231] [web] Enable SO_REUSEADDR on listen sockets
for WebFront…
URL: https://github.com/apache/flink/pull/5920

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/WebFrontendBootstrap.java
index 740beaee1cb..3d8e36b4f3f 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/WebFrontendBootstrap.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/utils/WebFrontendBootstrap.java
@@ -29,6 +29,7 @@
 import org.apache.flink.shaded.netty4.io.netty.channel.Channel;
 import org.apache.flink.shaded.netty4.io.netty.channel.ChannelFuture;
 import org.apache.flink.shaded.netty4.io.netty.channel.ChannelInitializer;
+import org.apache.flink.shaded.netty4.io.netty.channel.ChannelOption;
 import org.apache.flink.shaded.netty4.io.netty.channel.nio.NioEventLoopGroup;
 import org.apache.flink.shaded.netty4.io.netty.channel.socket.SocketChannel;
 import org.apache.flink.shaded.netty4.io.netty.channel.socket.nio.NioServerSocketChannel;
@@ -103,7 +104,8 @@ protected void initChannel(SocketChannel ch) {
 			.group(bossGroup, workerGroup)
-			.childHandler(initializer);
+			.childHandler(initializer)
+			.option(ChannelOption.SO_REUSEADDR, true);
 		ChannelFuture ch;
 		if (configuredAddress == null) {


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Enable SO_REUSEADDR on listen sockets
> -------------------------------------
>                 Key: FLINK-9231
>                 URL: https://issues.apache.org/jira/browse/FLINK-9231
>             Project: Flink
>          Issue Type: Improvement
>          Components: Webfrontend
>            Reporter: Ted Yu
>            Assignee: Triones Deng
>            Priority: Major
>              Labels: pull-request-available
> This allows sockets to be bound even if there are sockets from a previous application
that are still pending closure.

This message was sent by Atlassian JIRA

View raw message