flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9739) Regression in supported filesystems for RocksDB
Date Mon, 13 Aug 2018 14:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578333#comment-16578333
] 

ASF GitHub Bot commented on FLINK-9739:
---------------------------------------

zentol commented on a change in pull request #6452: [FLINK-9739] Regression in supported filesystems
for RocksDB
URL: https://github.com/apache/flink/pull/6452#discussion_r209628463
 
 

 ##########
 File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
 ##########
 @@ -535,10 +535,12 @@ else if (paths.length == 0) {
 						path = rawPath;
 					}
 				}
-
+				if (path.equalsIgnoreCase("file")) {
+					continue;
 
 Review comment:
   This means that `pp[i]` remains null, which we should avoid. We'll have to build a `List<File>`
instead and convert it to a `File[]`.
   
   Additionally we should document with a comment why we ignore this path here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Regression in supported filesystems for RocksDB
> -----------------------------------------------
>
>                 Key: FLINK-9739
>                 URL: https://issues.apache.org/jira/browse/FLINK-9739
>             Project: Flink
>          Issue Type: Bug
>          Components: FileSystem, State Backends, Checkpointing
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Sampath Bhat
>            Priority: Major
>              Labels: pull-request-available
>
> A user reporter on the [mailing list|http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Checkpointing-in-Flink-1-5-0-tt21173.html]
has reported that the {{RocksDBStateBackend}} no longer supports GlusterFS mounted volumes.
> Configuring {{file:///home/abc/share}} lead to an exception that claimed the path to
not be absolute.
> This was working fine in 1.4.2.
> In FLINK-6557 the {{RocksDBStateBackend}} was refactored to use java {{Files}} instead
of Flink {{Paths}}, potentially causing the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message