flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9936) Mesos resource manager unable to connect to master after failover
Date Thu, 02 Aug 2018 17:07:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567081#comment-16567081

ASF GitHub Bot commented on FLINK-9936:

tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207293251

 File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
 @@ -894,17 +900,21 @@ public void grantLeadership(final UUID newLeaderSessionID) {
 				// clear the state if we've been the leader before
 				if (getFencingToken() != null) {
-					clearState();
+					clearStateInternal();
 				slotManager.start(getFencingToken(), getMainThreadExecutor(), new ResourceActionsImpl());
-				getRpcService().execute(
-					() ->
+				prepareLeadershipAsync()
+					.exceptionally(t -> {
+						onFatalError(t);
+						return null;
+					})
 Review comment:
   Let's move the exception handling at the very end. That way we can also catch if `confirmLeaderSessionID`
fails. In all cases, we should call `onFatalError`.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Mesos resource manager unable to connect to master after failover
> -----------------------------------------------------------------
>                 Key: FLINK-9936
>                 URL: https://issues.apache.org/jira/browse/FLINK-9936
>             Project: Flink
>          Issue Type: Bug
>          Components: Mesos, Scheduler
>    Affects Versions: 1.5.0, 1.5.1, 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Gary Yao
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.5.3, 1.6.0
> When deployed in mesos session cluster mode, the connector monitor keeps reporting unable
to connect to mesos after restart. In fact, scheduler driver already connected to mesos master,
but when the connected message is lost. This is because leadership is not granted yet and
fence id is not set, the rpc service ignores the connected message. So we should connect to
mesos master after leadership is granted.

This message was sent by Atlassian JIRA

View raw message