flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9936) Mesos resource manager unable to connect to master after failover
Date Thu, 02 Aug 2018 17:07:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567084#comment-16567084
] 

ASF GitHub Bot commented on FLINK-9936:
---------------------------------------

tillrohrmann commented on a change in pull request #6464: [FLINK-9936][mesos] WIP 
URL: https://github.com/apache/flink/pull/6464#discussion_r207294014
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -345,15 +382,20 @@ private void recoverWorkers() throws Exception {
 		CompletableFuture<Boolean> stopReconciliationCoordinatorFuture = stopActor(reconciliationCoordinator,
stopTimeout);
 		reconciliationCoordinator = null;
 
-		CompletableFuture<Void> stopFuture = CompletableFuture.allOf(
+		return CompletableFuture.allOf(
 			stopTaskMonitorFuture,
 			stopConnectionMonitorFuture,
 			stopLaunchCoordinatorFuture,
 			stopReconciliationCoordinatorFuture);
+	}
+
+	@Override
+	public CompletableFuture<Void> postStop() {
+		final CompletableFuture<Void> supportActorsStopFuture = stopSupportingActorsAsync();
 
 		final CompletableFuture<Void> terminationFuture = super.postStop();
 
 Review comment:
   I think we should call `super.postStop` only after `supportActorsStopFuture` has been completed.
Otherwise we might risk that the parent class shuts some resources down which are used by
the support actors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Mesos resource manager unable to connect to master after failover
> -----------------------------------------------------------------
>
>                 Key: FLINK-9936
>                 URL: https://issues.apache.org/jira/browse/FLINK-9936
>             Project: Flink
>          Issue Type: Bug
>          Components: Mesos, Scheduler
>    Affects Versions: 1.5.0, 1.5.1, 1.6.0
>            Reporter: Renjie Liu
>            Assignee: Gary Yao
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.5.3, 1.6.0
>
>
> When deployed in mesos session cluster mode, the connector monitor keeps reporting unable
to connect to mesos after restart. In fact, scheduler driver already connected to mesos master,
but when the connected message is lost. This is because leadership is not granted yet and
fence id is not set, the rpc service ignores the connected message. So we should connect to
mesos master after leadership is granted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message