flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9938) State TTL cleanup during full state scan upon checkpointing
Date Fri, 03 Aug 2018 14:39:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568267#comment-16568267
] 

ASF GitHub Bot commented on FLINK-9938:
---------------------------------------

azagrebin commented on a change in pull request #6460: [FLINK-9938] Clean up full snapshot
from expired state with TTL
URL: https://github.com/apache/flink/pull/6460#discussion_r207566014
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTableSnapshot.java
 ##########
 @@ -217,12 +223,29 @@ protected void reportAllElementKeyGroups() {
 			int flattenIndex = 0;
 			for (CopyOnWriteStateTable.StateTableEntry<K, N, S> entry : partitioningDestination)
{
 				while (null != entry) {
-					final int keyGroup = KeyGroupRangeAssignment.assignToKeyGroup(entry.key, totalKeyGroups);
-					reportKeyGroupOfElementAtIndex(flattenIndex, keyGroup);
-					partitioningSource[flattenIndex++] = entry;
+					CopyOnWriteStateTable.StateTableEntry<K, N, S> filteredEntry = filterEntry(entry);
 
 Review comment:
   I think we can extend this class with filtering and use extension only if there is an actual
filter.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> State TTL cleanup during full state scan upon checkpointing
> -----------------------------------------------------------
>
>                 Key: FLINK-9938
>                 URL: https://issues.apache.org/jira/browse/FLINK-9938
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.6.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> We can try to piggyback full state scan during certain checkpoint processes in backends,
check TTL expiration for every entry and evict expired to speed up cleanup.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message