flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-9979) Support a custom FlinkKafkaPartitioner for a Kafka table sink factory
Date Wed, 01 Aug 2018 06:40:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-9979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564820#comment-16564820

ASF GitHub Bot commented on FLINK-9979:

tzulitai commented on a change in pull request #6440: [FLINK-9979] [table] Support a FlinkKafkaPartitioner
for Kafka table sink factory
URL: https://github.com/apache/flink/pull/6440#discussion_r206767191

 File path: flink-connectors/flink-connector-kafka-0.10/src/main/java/org/apache/flink/streaming/connectors/kafka/Kafka010TableSink.java
 @@ -51,11 +52,11 @@ public Kafka010TableSink(
 			String topic,
 			Properties properties,
 			SerializationSchema<Row> serializationSchema,
-			FlinkKafkaPartitioner<Row> partitioner) {
+			Optional<FlinkKafkaPartitioner<Row>> partitioner) {
 		return new FlinkKafkaProducer010<>(
-			partitioner);
+			partitioner.orElse(null));
 Review comment:
   Why is the default here `null`, while for the JSON table sink it is the `FlinkFixedPartitioner`?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Support a custom FlinkKafkaPartitioner for a Kafka table sink factory
> ---------------------------------------------------------------------
>                 Key: FLINK-9979
>                 URL: https://issues.apache.org/jira/browse/FLINK-9979
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
> Currently, the Kafka table sink factory does not support a custom FlinkKafkaPartitioner.
However, this is needed for many use cases.

This message was sent by Atlassian JIRA

View raw message