flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10005) StreamingFileSink ignores checkpoint/processing time rolling policies
Date Wed, 01 Aug 2018 07:39:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564895#comment-16564895

ASF GitHub Bot commented on FLINK-10005:

zentol commented on a change in pull request #6466: [FLINK-10005][DataStream API] StreamingFileSink:
sets initialPartCounter=maxUsed in new Buckets
URL: https://github.com/apache/flink/pull/6466#discussion_r206779932

 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
 @@ -237,7 +234,7 @@ void onElement(IN value, SinkFunction.Context context) throws Exception
-					initMaxPartCounter,
+					maxPartCounterUsed,
 			activeBuckets.put(bucketId, bucket);
 Review comment:
   can we add a comment just below that `final PartFileInfo<BucketID> info = bucket.getInProgressPartInfo();`
is `null`  directly after a snapshot and for new empty buckets? This is the detail I was missing
when trying to understand how this fixes the issue.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> StreamingFileSink ignores checkpoint/processing time rolling policies
> ---------------------------------------------------------------------
>                 Key: FLINK-10005
>                 URL: https://issues.apache.org/jira/browse/FLINK-10005
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming Connectors
>    Affects Versions: 1.6.0
>            Reporter: Chesnay Schepler
>            Assignee: Kostas Kloudas
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.6.0
> The {{StreamingFileSink}} supports different policies to determine whether a new part
file should be created; on each checkpoint, once a certain size is reached or on processing
> This feature only works correctly for size thresholds, other policies are ignored.

This message was sent by Atlassian JIRA

View raw message