flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10101) Mesos web ui url is missing.
Date Tue, 14 Aug 2018 17:42:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16580141#comment-16580141
] 

ASF GitHub Bot commented on FLINK-10101:
----------------------------------------

GJL commented on a change in pull request #6522: [FLINK-10101][mesos] Add web ui url for mesos.
URL: https://github.com/apache/flink/pull/6522#discussion_r210037022
 
 

 ##########
 File path: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManager.java
 ##########
 @@ -237,6 +244,10 @@ protected void initialize() throws ResourceManagerException {
 		Protos.FrameworkInfo.Builder frameworkInfo = mesosConfig.frameworkInfo()
 			.clone()
 			.setCheckpoint(true);
+		if (webUiUrl != null) {
+			frameworkInfo = frameworkInfo.setWebuiUrl(webUiUrl);
 
 Review comment:
   It is not needed to reassign `frameworkInfo` because the method has side-effects on the
builder. The return type is only a builder to enable method chaining. In fact, `frameworkInfo`
can be declared `final`. 
   ```
   if (webUiUrl != null) {
       frameworkInfo.setWebuiUrl(webUiUrl);
   }
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Mesos web ui url is missing.
> ----------------------------
>
>                 Key: FLINK-10101
>                 URL: https://issues.apache.org/jira/browse/FLINK-10101
>             Project: Flink
>          Issue Type: Bug
>          Components: Mesos
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2
>            Reporter: Renjie Liu
>            Assignee: Renjie Liu
>            Priority: Major
>              Labels: pull-request-available
>
> Mesos web ui url is missing in new deploy mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message