flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10110) Harden e2e Kafka shutdown
Date Thu, 09 Aug 2018 09:39:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574568#comment-16574568
] 

ASF GitHub Bot commented on FLINK-10110:
----------------------------------------

tillrohrmann opened a new pull request #6531: [FLINK-10110][tests] Harden Kafka component
shut down for E2E tests
URL: https://github.com/apache/flink/pull/6531
 
 
   ## What is the purpose of the change
   
   Instead of only calling kafka-server-stop.sh and zookeeper-server-stop.sh which can fail
   due to KAFKA-4931 we also use jps to kill the Kafka and ZooKeeper processes.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Harden e2e Kafka shutdown
> -------------------------
>
>                 Key: FLINK-10110
>                 URL: https://issues.apache.org/jira/browse/FLINK-10110
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.1, 1.7.0
>
>
> Due to KAFKA-4931, the shutdown of Kafka components can fail if the output of {{ps}}
is limited to 4096 characters. Therefore, it can happen that e2e tests which start Kafka don't
properly shut it down. I suggest to fix this problem by hardening our {{stop_kafka_cluster}}
in {{kafka-common.sh}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message