flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-10222) Table scalar function expression parses error when function name equals the exists keyword suffix
Date Tue, 28 Aug 2018 09:35:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594755#comment-16594755
] 

ASF GitHub Bot commented on FLINK-10222:
----------------------------------------

yanghua opened a new pull request #6622: [FLINK-10222] Table scalar function expression parses
error when function name equals the exists keyword suffix
URL: https://github.com/apache/flink/pull/6622
 
 
   ## What is the purpose of the change
   
   *This pull request fix Table scalar function expression parses error when function name
equals the exists keyword suffix*
   
   
   ## Brief change log
   
     - *uses an exact matching mode for some suffix keyword*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *KeywordAsSuffixTest#testFunctionNameContainsSuffixKeyword*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Table scalar function expression parses error when function name equals the exists keyword
suffix
> -------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-10222
>                 URL: https://issues.apache.org/jira/browse/FLINK-10222
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>
> Suffix extraction in ExpressionParser.scala does not actually support extraction of keywords
with the same prefix. For example: Adding suffix parsing rules for {{a.fun}} and {{a.function}}
simultaneously will causes exceptions. 
> some discussion : 
> [https://github.com/apache/flink/pull/6432#issuecomment-416127815]
> https://github.com/apache/flink/pull/6585#discussion_r212797015



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message