flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tillrohrmann commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService in a dedicated actor system
Date Tue, 02 Oct 2018 13:42:39 GMT
tillrohrmann commented on a change in pull request #6759: [FLINK-10247][Metrics] Run MetricQueryService
in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#discussion_r221949524
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutorGateway.java
 ##########
 @@ -195,4 +195,11 @@
 	 * @return Future which is completed with the {@link TransientBlobKey} of the uploaded file.
 	 */
 	CompletableFuture<TransientBlobKey> requestFileUpload(FileType fileType, @RpcTimeout
Time timeout);
+
+	/**
+	 * Returns the fully qualified address of Metric Query Service on the TaskManager.
+	 *
+	 * @return Fully qualified (RPC) address of Metric Query Service on the TaskManager.
+	 */
+	String getMetricQueryServiceAddress();
 
 Review comment:
   All methods of the `TaskExecutorGateway` represent an RPC. Thus, it should return a `CompletableFuture<String>
foobar(@RpcTimeout Time timeout);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message