flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] tillrohrmann opened a new pull request #6821: [FLINK-10524] Retry MemoryManager#release if NoSuchElementException
Date Thu, 11 Oct 2018 08:08:53 GMT
tillrohrmann opened a new pull request #6821: [FLINK-10524] Retry MemoryManager#release if
NoSuchElementException
URL: https://github.com/apache/flink/pull/6821
 
 
   ## What is the purpose of the change
   
   The MemoryManager#release method retries in case of ConcurrentModificationExceptions because
   memory can be released concurrently. In case of concurrent releases we can also see a
   NoSuchElementException if we are in the ArrayList.Itr#next call past the concurrent modification
   check and try to access, for example, an index which is exceeding the ArrayList's size.
Thus,
   we should also retry on seeing a NoSuchElementException because it indicates a concurrent
   modification.
   
   ## Verifying this change
   
   - Covered by `MemoryManagerConcurrentModReleaseTest.testConcurrentModificationWhileReleasing`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message