flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zhijiangW commented on issue #6705: [FLINK-10356][network] add sanity checks to SpillingAdaptiveSpanningRecordDeserializer
Date Tue, 16 Oct 2018 04:48:01 GMT
zhijiangW commented on issue #6705: [FLINK-10356][network] add sanity checks to SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#issuecomment-430099420
 
 
   @NicoK , thanks for this improvement and I think it is actually necessary to add some checks
during the deserialization, otherwise it is difficult to find hidden problems or debug.
   
   I reviewed the whole processes except the tests currently. I am only not very understanding
the usages of `getDeserializationError` in one place. Maybe need your further explanation
for clarification. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message