flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] TisonKun commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase
Date Wed, 17 Oct 2018 07:56:12 GMT
TisonKun commented on issue #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#issuecomment-430528080
 
 
   @yanghua changes LGTM and for your statement on "block FLINK-10292", it should have not
been.
   Document on Junit announces:
   ```java
   /**
        * If called with an expression evaluating to {@code false}, the test will halt and
be ignored.
        *
        * @param b If <code>false</code>, the method will attempt to stop the
test and ignore it by
        * throwing {@link AssumptionViolatedException}.
        * @param message A message to pass to {@link AssumptionViolatedException}.
        */
       public static void assumeTrue(String message, boolean b) {
           if (!b) throw new AssumptionViolatedException(message);
       }
   ```
   So the error message occurs on https://api.travis-ci.org/v3/job/439612829/log.txt can be
ignored. Also I'd like to get input from @zentol to see if the test env has some trouble.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message