flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] TisonKun opened a new pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
Date Wed, 17 Oct 2018 23:47:18 GMT
TisonKun opened a new pull request #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872
 
 
   ## What is the purpose of the change
   
   Add `ConfigOption#withFallbackKeys` to implement a similar function with `ConfigOption#withDeprecatedKeys`.
That is, the `fallbackKey` falls back to current key if it has not been specified, but the
use of current key would not print a deprecated message.
   
   ## Brief change log
   
   - Introduce `FallbackKey` class to represent a key with `isDeprecated` message.
   - Replace `deprecatedKeys` to `fallbackKeys` in `ConfigOption`
   
   
   ## Verifying this change
   
   - Add a test `ConfigurationTest#testFallbackKeys` to check the fallback mechanism works.
   - Manually check the issue report by the corresponding JIRA disappear.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   cc @tillrohrmann 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message