flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] link3280 opened a new pull request #6932: [Flink-10680][streaming] Fix IllegalArgumentException caused by negative offset in TumblingWindows
Date Fri, 26 Oct 2018 01:34:29 GMT
link3280 opened a new pull request #6932: [Flink-10680][streaming] Fix IllegalArgumentException
caused by negative offset in TumblingWindows
URL: https://github.com/apache/flink/pull/6932
 
 
   ## What is the purpose of the change
   
   By design, the offset could be either positive or negative to fit in different time zones,
but there's a check that ensures the offset is greater than zero. 
   
   This PR fixes the IllegalArguementException caused by negative offsets in TumblingEventTimeWindows
and TumblingProcessingTimeWindows.
   
   ## Brief change log
   
   - Change the condition of the parameter checks in TumblingEventTimeWindows and TumblingProcessingTimeWindows
from `0 <= offset < size` to `0 <= abs(offset) < size`.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   - Updated the tests for invalid parameters for time window assigners.
   - Added tests for negative offsets of time windows.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: no 
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?  no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message