flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2435) Add support for custom CSV field parsers
Date Mon, 01 Oct 2018 08:34:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633713#comment-16633713
] 

ASF GitHub Bot commented on FLINK-2435:
---------------------------------------

ex00 commented on a change in pull request #5862: [FLINK-2435] User-defined types in CsvReader
URL: https://github.com/apache/flink/pull/5862#discussion_r221250089
 
 

 ##########
 File path: flink-java/src/test/java/org/apache/flink/api/java/tuple/TupleGenerator.java
 ##########
 @@ -473,7 +534,7 @@ private static void appendTupleTypeGenerics(StringBuilder sb, int numFields)
{
 	}
 
 	private static final String HEADER =
-			"/*\n"
+		"/*\n"
 
 Review comment:
   please revert this change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add support for custom CSV field parsers
> ----------------------------------------
>
>                 Key: FLINK-2435
>                 URL: https://issues.apache.org/jira/browse/FLINK-2435
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataSet API
>    Affects Versions: 0.10.0
>            Reporter: Fabian Hueske
>            Assignee: Dmitrii Kober
>            Priority: Minor
>              Labels: pull-request-available
>
> The {{CSVInputFormats}} have only {{FieldParsers}} for Java's primitive types (byte,
short, int, long, float, double, boolean, String).
> It would be good to add support for CSV field parsers for custom data types which can
be registered in a {{CSVReader}}. 
> We could offer two interfaces for field parsers.
> 1. The regular low-level {{FieldParser}} which operates on a byte array and offsets.
> 2. A {{StringFieldParser}} which operates on a String that has been extracted by a {{StringParser}}
before. This interface will be easier to implement but less efficient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message