flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5542) YARN client incorrectly uses local YARN config to check vcore capacity
Date Mon, 08 Oct 2018 09:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641584#comment-16641584

ASF GitHub Bot commented on FLINK-5542:

GJL commented on a change in pull request #6775: [FLINK-5542] use YarnCluster vcores setting
to do MaxVCore validation
URL: https://github.com/apache/flink/pull/6775#discussion_r223300816

 File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 @@ -282,18 +282,29 @@ private void isReadyForDeployment(ClusterSpecification clusterSpecification)
 		// Check if we don't exceed YARN's maximum virtual cores.
-		// The number of cores can be configured in the config.
-		// If not configured, it is set to the number of task slots
-		int numYarnVcores = yarnConfiguration.getInt(YarnConfiguration.NM_VCORES, YarnConfiguration.DEFAULT_NM_VCORES);
+		// Fetch numYarnMaxVcores from all the RUNNING nodes via yarnClient
+		int numYarnMaxVcores = Integer.MIN_VALUE;
 Review comment:
   How about:
   		final int numYarnMaxVcores;
   		try {
   			numYarnMaxVcores = yarnClient.getNodeReports(NodeState.RUNNING)
   				.mapToInt(report -> report.getCapability().getVirtualCores())
   		} catch (Exception e) {
   			throw new YarnDeploymentException("Couldn't get cluster description, please check on
the YarnConfiguration", e);
   Pros of doing so:
   - `numYarnMaxVcores` is final
   - If no NodeManagers are running at all, we would log `0` vcores instead of `Integer.MIN_VALUE`
   - Concise & easy to read

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> YARN client incorrectly uses local YARN config to check vcore capacity
> ----------------------------------------------------------------------
>                 Key: FLINK-5542
>                 URL: https://issues.apache.org/jira/browse/FLINK-5542
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>    Affects Versions: 1.1.4, 1.5.3, 1.6.0, 1.7.0
>            Reporter: Shannon Carey
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
> See http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/1-1-4-on-YARN-vcores-change-td11016.html
> When using bin/yarn-session.sh, AbstractYarnClusterDescriptor line 271 in 1.1.4 is comparing
the user's selected number of vcores to the vcores configured in the local node's YARN config
(from YarnConfiguration eg. yarn-site.xml and yarn-default.xml). It incorrectly prevents Flink
from launching even if there is sufficient vcore capacity on the cluster.
> That is not correct, because the application will not necessarily run on the local node.
For example, if running the yarn-session.sh client from the AWS EMR master node, the vcore
count there may be different from the vcore count on the core nodes where Flink will actually
> A reasonable way to fix this would probably be to reuse the logic from "yarn-session.sh
-q" (FlinkYarnSessionCli line 550) which knows how to get vcore information from the real
worker nodes.  Alternatively, perhaps we could remove the check entirely and rely on YARN's
Scheduler to determine whether sufficient resources exist.

This message was sent by Atlassian JIRA

View raw message